Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add multi-srp support to the background script #29942

Draft
wants to merge 18 commits into
base: main
Choose a base branch
from
Draft

feat: add multi-srp support to the background script #29942

wants to merge 18 commits into from

Conversation

montelaidev
Copy link
Contributor

@montelaidev montelaidev commented Jan 28, 2025 •
edited by github-actions bot
Loading

Description

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@socket-security Socket Security
Copy link

socket-security bot commented Jan 28, 2025 •
edited
Loading

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/[email protected] None 0 0 B
npm/@scure/[email protected] 🔁 npm/@scure/[email protected] None 0 133 kB paulmillr
npm/[email protected] 🔁 npm/[email protected] None 0 31 kB sheetjs
npm/[email protected] None 0 23 kB alizain

🚮 Removed packages: npm/[email protected], npm/[email protected]

View full report↗︎

@montelaidev
Copy link
Contributor Author

@metamaskbot update-policies

@metamaskbot
Copy link
Collaborator

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

@metamaskbot
Copy link
Collaborator

Builds ready [b714456]
Page Load Metrics (1648 ± 54 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint14642017166211957
domContentLoaded14551946162510852
load14641951164811254
domInteractive237436189
backgroundConnect116227178
firstReactRender1597452914
getState490192311
initialActions00000
loadScripts995141811699546
setupStore75719189
uiStartup16962619190420799
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 218 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 55.4 KiB (0.59%)

@metamaskbot
Copy link
Collaborator

Builds ready [0312f63]
Page Load Metrics (1708 ± 104 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint38221801572420202
domContentLoaded143021641691217104
load143921851708216104
domInteractive2286402110
backgroundConnect86425178
firstReactRender1672382412
getState46015189
initialActions01000
loadScripts9561553120617283
setupStore76314168
uiStartup160824811942247119
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 200 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 4.16 KiB (0.04%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
team-accounts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@montelaidev @metamaskbot